Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets typing_extensions minimum #168

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented May 17, 2023

We are using features that come after 4.0.0 and so we should set the minimum, else users will encounter errors if their version of typing_extensions isn't greater than 4.0.0.

Also fixed places in code where we were not checking appropriately for the right version and importing
from the right place.

Changes

  • requirements.txt
  • recursive.py

How I tested this

  • unit tests

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

We are using features that come after `4.0.0` and so
we should set the minimum, else users will encounter
errors if their version of typing_extensions isn't greater
than 4.0.0.

Also fixed places in code where we were not checking
appropriately for the right version and importing
from the right place.
@skrawcz skrawcz requested a review from elijahbenizzy May 17, 2023 20:37
@skrawcz skrawcz merged commit ad4a465 into main May 18, 2023
@skrawcz skrawcz deleted the fix_typing_inspect_min_version branch May 18, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant