Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds node attributes to visualize_execution based on context #169

Merged
merged 1 commit into from
May 18, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented May 18, 2023

For inputs -- they will be shown as dotted outlines. For outputs -- they will be shown as rectangles.
Changes UD -> Input to make it clearer what this is too.

This then leaves room for more attribute manipulation.

Adjusts unit tests accordingly.

Changes

  • graph.py
  • driver.py

How I tested this

  • unit tests
  • ran visualization example

Notes

  • TODO: regenerate all visualization images in docs.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

For inputs -- they will be shown as dotted outlines.
For outputs -- they will be shown as rectangles.

This then leaves room for more attribute manipulation.

Adjusts unit tests accordingly.
@skrawcz skrawcz requested a review from elijahbenizzy May 18, 2023 06:35
@skrawcz
Copy link
Collaborator Author

skrawcz commented May 18, 2023

my_dag dot

this is what things will look like now -- also change UD to Input.

@elijahbenizzy
Copy link
Collaborator

Looks good we should probably regenerate all the examples at some point?

@skrawcz
Copy link
Collaborator Author

skrawcz commented May 18, 2023

Looks good we should probably regenerate all the examples at some point?

yes it's a TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants