Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an example for LLM stack components #202

Merged
merged 9 commits into from
Jun 30, 2023
Merged

Added an example for LLM stack components #202

merged 9 commits into from
Jun 30, 2023

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Jun 27, 2023

[Short description explaining the high-level reason for the pull request]
Could add further features with answer generation!

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes and this is good to go! Thanks for the examples!

  1. Add DAG images to README (and code to produce it).
  2. Rebase this off of main, and put it in the new folder LLM_workflows
  3. Can you rename the example directories to something like "blog_to_vector_db" and "modular_llm_stack"?
  4. I left comments/suggestions otherwise.

examples/llm_stack/data_module.py Outdated Show resolved Hide resolved
examples/llm_stack/embedding_module.py Outdated Show resolved Hide resolved
examples/llm_stack/README.md Outdated Show resolved Hide resolved
examples/llm/README.md Outdated Show resolved Hide resolved
examples/llm/README.md Outdated Show resolved Hide resolved
examples/llm/README.md Outdated Show resolved Hide resolved
examples/llm/run.py Outdated Show resolved Hide resolved
examples/llm_stack/run.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to add instructions in the README for how to run things, and where to put API keys, etc.

@zilto zilto marked this pull request as ready for review June 30, 2023 17:02
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three changes:

  • spell out how to run docker container
  • provide example command line to cut and paste to run with weaviate
  • move this example to be in the same directory as the LLM_Workflows folder - do this as your last commit independent of the changes above, e.g. git mv modular_llm_stack LLM_Workflows/modular_llm_stack.

@skrawcz skrawcz merged commit 2316fc7 into DAGWorks-Inc:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants