-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an example for LLM stack components #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes and this is good to go! Thanks for the examples!
- Add DAG images to README (and code to produce it).
- Rebase this off of main, and put it in the new folder LLM_workflows
- Can you rename the example directories to something like "blog_to_vector_db" and "modular_llm_stack"?
- I left comments/suggestions otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need to add instructions in the README for how to run things, and where to put API keys, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three changes:
- spell out how to run docker container
- provide example command line to cut and paste to run with weaviate
- move this example to be in the same directory as the LLM_Workflows folder - do this as your last commit independent of the changes above, e.g.
git mv modular_llm_stack LLM_Workflows/modular_llm_stack
.
Updates README
[Short description explaining the high-level reason for the pull request]
Could add further features with answer generation!
Changes
How I tested this
Notes
Checklist