Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid get_dummies dtype change in pandas v2 (keep backwards compatible) #228

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

lmmx
Copy link
Contributor

@lmmx lmmx commented Jul 23, 2023

Changes

  • The dtype argument has been added to all uses of get_dummies, as the default value changed in pandas v2

How I tested this

  • python run.py no longer produces errors

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for catching and fixing. One quick question -- is this backwards compatible with pandas <2.X? If not, we could just bump the pandas minimum for the example.

@skrawcz
Copy link
Collaborator

skrawcz commented Jul 23, 2023

Actually just looked at the docs. The change in get_dummies was going from a default of unit8 to bool. So this will be backwards compatible with prior pandas versions.

@skrawcz skrawcz merged commit 1c95439 into DAGWorks-Inc:main Jul 23, 2023
@skrawcz
Copy link
Collaborator

skrawcz commented Jul 23, 2023

FYI - #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants