Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jupyter notebook version of scikit-learn example #263

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

AnupJoseph
Copy link
Contributor

Added a hamilton_notebook.ipynb towards the #247

Changes

How I tested this

Manually ran through example check and verified the results

Notes

Should I add the limitations and TODOs section as well into the notebook?

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Copy link
Collaborator

skrawcz commented Aug 9, 2023

Should I add the limitations and TODOs section as well into the notebook?

You can add a comment/reference to it. Don't think you need to replicate that fully.

Otherwise thanks for the addition! Will wait on your change regarding the limitations above, and will then merge it.

@AnupJoseph
Copy link
Contributor Author

Thanks! Have added a link to the limitations at the end of the notebook.

@skrawcz skrawcz merged commit 150dc68 into DAGWorks-Inc:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants