Add spark pdf summarizer example #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to handle things like list[str] so that we can handle the pdf_summarizer code. Also the code didn't handle optional dependencies, now it does.
skrawcz
changed the title
skrawcz
force-pushed
the
add_spark_pdf_summarizer
branch
3 times, most recently
from
6eaedab to
1807e6d
Compare
So that we get some coverage going in case we accidentally break something. Makes sure that we handle <3.9 appropriately too.
This example shows that you can run the same code in a FastAPI backend, and then turn around and run it on Spark as well! This is because flows like PDF summarization are essential “map” transformations, and can then be easily ported and modeled in spark. The magic to run on spark happens in the SparkUDFGraphAdapter. Otherwise, this adds and adjusts code to make the summarization.py code work on spark (one tweak was needed). We add everything for someone to run the example, including a script and notebook. Squashed commit of: Adds notebook to pdf spark example So that people can use that to get started too. (+4 squashed commits) Squashed commits: [7db102c] Removes unused code. [ce2abec] Adds missing requirements.txt for spark PDF example So that people know what to install. [eae3edd] Adds README to spark PDF post Renames directory to run_on_spark to make it clear. Adds pointer to main README to spark one. [154e3ce] Adds spark code to run PDF Summarizer We only needed one minor changes to the original code: * we have to ensure the order of "columns" versus values that can be bound are in the correct order. So we had to reorder one function's arguments for spark to work.
skrawcz
force-pushed
the
add_spark_pdf_summarizer
branch
from
3297b3f to
6460b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds example showing how to run the PDF summarizer on spark.
E.g. given a table, run the summarizer as a series of row based UDFs.
Changes
How I tested this
Notes
Checklist