Miscellaneous/usability fixes #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #238 -- this should make it marginally easier to debug.
elijahbenizzy
force-pushed
the
misc-fixes
branch
3 times, most recently
from
195fddb to
aaf3b58
Compare
See #188 for logic. Design is to pass, as the error message will be more helpful later on (when the specified node does not exist)
elijahbenizzy
force-pushed
the
misc-fixes
branch
from
aaf3b58 to
c30b858
Compare
elijahbenizzy
changed the title
skrawcz
approved these changes
Aug 15, 2023
hamilton/htypes.py
Outdated
Comment on lines
23
to
25
| if not inspect.isclass(base_type) or not inspect.isclass(candidate_type): | ||
| return False | ||
| return issubclass(candidate_type, base_type) |
There was a problem hiding this comment.
should have a unit test for this, no?
elijahbenizzy
force-pushed
the
misc-fixes
branch
2 times, most recently
from
ab6e9ad to
bdb4c66
Compare
Inspired by #42. Note that we make the design decision to not error out when we do a subclass check against generics. Rather, we return false. We then change the error message to show how they can proceed if their subclass check returns False.
elijahbenizzy
force-pushed
the
misc-fixes
branch
from
bdb4c66 to
88164ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #238 -- this should make it marginally easier to debug.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist