Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor minor fixes #279

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Executor minor fixes #279

merged 3 commits into from
Aug 17, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

We were previously doing execution incorrectly -- this adds additional
logging + sets up the correct executor to run for tasks.
@elijahbenizzy elijahbenizzy requested a review from skrawcz August 17, 2023 21:08
@skrawcz skrawcz changed the title Fix executors Executors minor fixes Aug 17, 2023
@skrawcz skrawcz changed the title Executors minor fixes Executor minor fixes Aug 17, 2023
@elijahbenizzy elijahbenizzy merged commit 820f4e1 into main Aug 17, 2023
@elijahbenizzy elijahbenizzy deleted the fix-executors branch August 17, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants