Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates DBT example data_loader #289

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Updates DBT example data_loader #289

merged 1 commit into from
Aug 23, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Aug 23, 2023

This is now more modern Hamilton code, and gels
better with the example.

Changes

  • just example

How I tested this

  • ran it locally.

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This is now more modern Hamilton code, and gels
better with the example.
@skrawcz skrawcz merged commit ab014a5 into main Aug 23, 2023
@skrawcz skrawcz deleted the dbt_example_tweaks branch August 23, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant