Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SparkSession import #291

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Fixes SparkSession import #291

merged 2 commits into from
Aug 24, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Aug 24, 2023

It was pulling it in via non-official module import. The correct way is the simpler one.
https://spark.apache.org/docs/3.4.1/sql-getting-started.html#starting-point-sparksession

Changes

  • fixes SparkSession import

How I tested this

  • ran spark examples locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

It was pulling it in via non-official module import.
The correct way is the simpler one.
https://spark.apache.org/docs/3.4.1/sql-getting-started.html#starting-point-sparksession
@elijahbenizzy
Copy link
Collaborator

Also remove connect from hamilton setup.py

@elijahbenizzy elijahbenizzy merged commit fd42544 into main Aug 24, 2023
@elijahbenizzy elijahbenizzy deleted the fix_spark_session_import branch August 24, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants