-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@pipe decorator #398
Merged
Merged
@pipe decorator #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
517b145
to
0af987d
Compare
b556623
to
03d2803
Compare
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
skrawcz
reviewed
Oct 17, 2023
in person conversation notes:
|
e678276
to
d49d9d3
Compare
skrawcz
approved these changes
Oct 19, 2023
Closed
skrawcz
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Commits should have more design decision whys for your future self to refer back to.
#372 `pipe` allows for function chaining/redefinition. It has a few caveats (see the documentation + list below), but they're all placeholders -- we will have the chance to improve it over time, as more people use it. - uses a series of `step(fn, *args, **kwargs)` to apply functions in a row - the first parameter is chained through to the next ones - we only support decorating hamilton-friendly functions (kwargable/typed) for now - we have an ability to make it a single node but don't do that yet We also place in/comment out the `@flow` decorator, which is equivalent to `pipe`, but doesn't pass the result into the next function. Thus it can be used to build a procedural subdag as a component of a declarative DAG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #65, #372
Changes
How I tested this
Notes
Checklist