Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a DataSaver to save matplotlib objects of type
matplotlib.figure.Figure
, i.e., resulting fromplt.figure()
andplt.subplots()
.Changes
Added a
matplotlib_extensions.py
with the DataSaver class and added it to the registryHow I tested this
Added a test to check the DataSaver properly writes to a file. I manually validated that the output file was correct.
Notes
path
argument objects of typeIO
(i.e., in-memory files, streams, etc.) which may fail whenhamilton.io.utils.get_file_metadata()
is called.Checklist