-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrib: update to LanceDB contrib #533
Conversation
Apply Sweep Rules to your PR?
|
|
||
# Configuration Options | ||
This module doesn't receive any configuration. | ||
|
||
## Inputs: | ||
## Required Inputs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "required"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that Inputs
might imply that is an exhaustive list of all the inputs. Instead, this list includes that you will have to pass as input to use the module albeit not all concurrently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think Inputs
is fine. No need to for that extra qualification. Hamilton should complain anyway if something isn't satisfied.
Looking good otherwise -- just that one question. |
For existing dataflows -- what has changed?
Added functions for vector and full text search and updated the README and the DAG accordingly.
How I tested this
Used a notebook running all the nodes.
Notes
Checklist