Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #537

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Bump version #537

merged 3 commits into from
Nov 14, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Nov 14, 2023

Various changes required to push out new version.

Changes

  • hamilton/dataflows/init.py
  • hub template

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Fixes dataflows inconsistencies
e2f9cde 
`inspect()` didn't follow the `dataflow`, `user` order
used throughout the other APIs.

Also caught that "official" was not taken care
of in the place where we inspect things.
@skrawcz
Fixes hub code examples typo
7626638 
dataflow -> dataflows should be the module.
@skrawcz
Bumps version to 1.38.0 and contrib to 0.0.2
5b4cb23 
So that we can push out a few fixes and hub related
changes.
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@skrawcz skrawcz merged commit 62441a1 into main Nov 14, 2023
@skrawcz skrawcz deleted the bump_version branch November 14, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skrawcz