Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes type annotation on DB connection to Any #543

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Nov 18, 2023

This was unnecessarily restrictive. The original
pandas doesn't have a type here. So need to put Any for our type system to work.

Changes

  • changes type annotation

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This was unnecessarily restrictive. The original
pandas doesn't have a type here. So need to put Any
for our type system to work.
Copy link
Contributor

sweep-ai bot commented Nov 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@elijahbenizzy elijahbenizzy self-requested a review November 18, 2023 18:25
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skrawcz skrawcz merged commit f50e0fd into main Nov 20, 2023
@skrawcz skrawcz deleted the fix_write_sql_type_annotation branch November 20, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants