Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check script #547

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix version check script #547

merged 2 commits into from
Nov 20, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Nov 20, 2023

Fixes version check script

There is something funky going on. This only just suddenly started to break.
So it could be we were just lucky and now some installation non-determinism
is throwing things off, or something else changed...

Otherwise this hacks around the case of pip install -e . not doing the
correct thing due the package structure we've set up.

Changes

  • script changes

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

There is something funky going on. This only just suddenly started to break.
So it could be we were just lucky and now some installation non-determinism
is throwing things off, or something else changed...

Otherwise this hacks around the case of `pip install -e .` not doing the
correct thing due the package structure we've set up.
To push out new additions.
Copy link
Contributor

sweep-ai bot commented Nov 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@skrawcz skrawcz merged commit b23a94b into main Nov 20, 2023
2 checks passed
@skrawcz skrawcz deleted the fix_version_check branch November 20, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant