Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors out when calling create_temporary_module with functions that #558

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Nov 27, 2023

start with "_"

See #510

This is not backwards compatible, but this is a specific "ad-hoc" util and has an easy fix, so I'm OK not bumping versions accordingly. I would consider this previously undefined behavior, and this will make debugging easier.

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

sweep-ai bot commented Nov 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@elijahbenizzy elijahbenizzy force-pushed the validate-functions-ad-hoc-modules branch from 2cb73a2 to aaf966f Compare November 27, 2023 04:46
@elijahbenizzy
Copy link
Collaborator Author

See #510

start with "_"

See #510

This is *not* backwards compatible, but this is a specific "ad-hoc" util
and has an easy fix, so I'm OK not bumping versions accordingly. I would
consider this previously undefined behavior, and this will make
debugging easier.
@elijahbenizzy elijahbenizzy force-pushed the validate-functions-ad-hoc-modules branch from aaf966f to e7d8ebc Compare November 27, 2023 04:48
@elijahbenizzy elijahbenizzy merged commit 7886a67 into main Nov 27, 2023
@elijahbenizzy elijahbenizzy deleted the validate-functions-ad-hoc-modules branch November 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants