Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates pre-commit hooks #568

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Updates pre-commit hooks #568

merged 1 commit into from
Nov 28, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

Fixes pre-commit hooks to be newer

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 28, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@elijahbenizzy
Copy link
Collaborator Author

This is broken because of this: PyCQA/isort#1889. Figuring out how to fix.

skrawcz
skrawcz approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but update the commit message as to why.

@elijahbenizzy
Updates pre-commit hooks
cd203ed 
Fixes pre-commit hooks. TBD what was happening, but this updates
everything, and adds known_first_party to disambiguate the use of the
hamilton package. Should make it stable across all systems, and ensures
we use the latest linting/checking rules.
@elijahbenizzy elijahbenizzy merged commit f9eed74 into main Nov 28, 2023
2 checks passed
@elijahbenizzy elijahbenizzy deleted the update-pre-commit branch November 28, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijahbenizzy @skrawcz