Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes parallel case with empty list #569

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Nov 28, 2023

This was broken as we assumed the list was not empty. This special-cases it. We should probably be breaking this into functions so we can add more unit tests, but given the experimental nature of this I'm not worried. Don't want to over-engineer. The fix will work nicely for now.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

sweep-ai bot commented Nov 28, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@elijahbenizzy elijahbenizzy force-pushed the fix-parallel-empty-list branch from 3518c03 to cfff0a0 Compare November 28, 2023 21:39
This was broken as we assumed the list was not empty. This special-cases
it. We should probably be breaking this into functions so we can add
more unit tests, but given the experimental nature of this I'm not
worried. Don't want to over-engineer. The fix will work nicely for now.
@elijahbenizzy elijahbenizzy force-pushed the fix-parallel-empty-list branch from cfff0a0 to 88b1cbe Compare November 28, 2023 21:43
@elijahbenizzy elijahbenizzy merged commit cfc72e3 into main Nov 28, 2023
@elijahbenizzy elijahbenizzy deleted the fix-parallel-empty-list branch November 28, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants