Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks error message to make it harder to miss #579

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Dec 7, 2023

Adds a block to explicitly make it hard to not miss which node threw the error.

ERROR:hamilton.execution.graph_functions:
****************************************
> Node spend_mean encountered an error <
****************************************

Changes

  • graph_functions.py

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Adds a block to explicitly make it hard to not miss which node
threw the error.
@skrawcz skrawcz requested a review from elijahbenizzy December 7, 2023 22:12
Copy link
Contributor

sweep-ai bot commented Dec 7, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@elijahbenizzy elijahbenizzy merged commit 42cdae3 into main Dec 7, 2023
@elijahbenizzy elijahbenizzy deleted the tweak_node_error branch December 7, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants