Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bytesIO/bytes input for to.file #610

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Adds bytesIO/bytes input for to.file #610

merged 1 commit into from
Dec 28, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Dec 28, 2023

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

sweep-ai bot commented Dec 28, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@elijahbenizzy elijahbenizzy force-pushed the add-bytes-io branch 3 times, most recently from 9dd5ac5 to 08c879e Compare December 28, 2023 04:54
This helps when we want to save binary data
@elijahbenizzy elijahbenizzy marked this pull request as ready for review December 28, 2023 04:59
@elijahbenizzy elijahbenizzy merged commit fb10017 into main Dec 28, 2023
22 checks passed
@elijahbenizzy elijahbenizzy deleted the add-bytes-io branch December 28, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants