Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/streamlit integration #643

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Docs/streamlit integration #643

merged 5 commits into from
Jan 16, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Jan 16, 2024

Added a documentation page with practical instructions on how to use Hamilton + Streamlit and its benefits.

Changes

  • Added a page to the docs

How I tested this

  • built the docs and viewed them locally

@zilto zilto added the documentation Improvements or additions to documentation label Jan 16, 2024
@DAGWorks-Inc DAGWorks-Inc deleted a comment from sweep-ai bot Jan 16, 2024
skrawcz
skrawcz approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Just need the link to streamlit for people who don't know what it is.

elijahbenizzy
elijahbenizzy reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few nits

docs/integrations/streamlit.md Show resolved Hide resolved
examples/streamlit/logic.py Show resolved Hide resolved
@zilto zilto merged commit b58954d into main Jan 16, 2024
22 checks passed
@zilto zilto deleted the docs/streamlit-integration branch January 16, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elijahbenizzy elijahbenizzy elijahbenizzy left review comments

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zilto @skrawcz @elijahbenizzy