Fix path metadata #686
Merged
Fix path metadata #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
fix-path-metadata
branch
2 times, most recently
from
8345e45 to
fc31a71
Compare
skrawcz
reviewed
Feb 8, 2024
hamilton/io/utils.py
Outdated
| if isinstance(path, Path): | ||
| path = str(path) | ||
| parsed = parse.urlparse(path) | ||
| size = 0 |
There was a problem hiding this comment.
this should be None or -1. 0 could be a real value.
There was a problem hiding this comment.
Fair, I think None is probably fine
elijahbenizzy
force-pushed
the
fix-path-metadata
branch
from
fc31a71 to
4e6d4dd
Compare
skrawcz
reviewed
Feb 8, 2024
skrawcz
approved these changes
Feb 8, 2024
Pandas and other tools can read from, say, s3. Our get_file_metadata will currently break. This fixes it, adding default values + a note that says that metadata is not supported. We will want to add more metadata gatherer plugins later, but this is not necessary.
elijahbenizzy
force-pushed
the
fix-path-metadata
branch
from
4e6d4dd to
5e8122e
Compare
skrawcz
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes path metadata for s3/other URLs.
Changes
How I tested this
Notes
Checklist