-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating documentation to fit with diataxis.fr approach #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
changed the title
Adds basic instructions for building/running docs locally
Migrating documentation to fit with diataxis.fr approach
Feb 26, 2023
This adds links to the tutorial, and cleans up pieces.
* Changes open source email address to the correct one * Fills out overview of concepts * Update docs/concepts/best-practices/function-modifiers.rst Co-authored-by: Stefan Krawczyk <stefan@dagworks.io> * Update docs/concepts/customizing-execution.rst Co-authored-by: Stefan Krawczyk <stefan@dagworks.io> * Update docs/concepts/decorators-overview.rst Co-authored-by: Stefan Krawczyk <stefan@dagworks.io> * Update docs/concepts/customizing-execution.rst Co-authored-by: Stefan Krawczyk <stefan@dagworks.io> * Update docs/concepts/decorators-overview.rst Co-authored-by: Stefan Krawczyk <stefan@dagworks.io> --------- Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
So that it's clear how to get started/install things and when to us myST and when to use reST.
Added extensions are for creating reference docs from our python files easily. Otherwise it adds the hamilton repo to the path when sphinx consumes conf.py. This will mean that the hamilton code is now accessible to be referenced for when we want to create documentation from those modules. Note: sphinx will need to have all the right python dependencies in order to be able to parse that python file.
So that you can change function doc and it'll rebuild the docs.
This is still WIP, but committing to be able to pull and update changes as needed.
This is probably good enough for now. This isn't a bad way to do things, it forces more documentation into the class string of the decorators. It also means that we cannot be sloppy in the reST string of constructors either.
This should subsume what was there previously. The docs themselves aren't that pretty -- they could use a little more whitespace. But otherwise good enough for now.
This is pretty basic. Still need to flesh out the function doc a bit.
skrawcz
force-pushed
the
diataxis-docs
branch
from
February 27, 2023 05:10
595cd6a
to
27c0d41
Compare
We have documents with content to migrate.
So that way we can easily include the main README as the landing page for the documentation. Fixes blog, talks, posts to include newer content.
So that we catch weird indentation warnings in dev. Adds to requirements-docs.txt what readthedocs installs. Note with myst we can't use the latest sphinx docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist