Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating documentation to fit with diataxis.fr approach #71

Merged
merged 20 commits into from
Feb 27, 2023
Merged

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy changed the title Adds basic instructions for building/running docs locally Migrating documentation to fit with diataxis.fr approach Feb 26, 2023
elijahbenizzy and others added 15 commits February 26, 2023 21:08
This adds links to the tutorial, and cleans up pieces.
* Changes open source email address to the correct one

* Fills out overview of concepts

* Update docs/concepts/best-practices/function-modifiers.rst

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/customizing-execution.rst

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/decorators-overview.rst

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/customizing-execution.rst

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/decorators-overview.rst

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

---------

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
So that it's clear how to get started/install things and when
to us myST and when to use reST.
Added extensions are for creating reference docs from our python
files easily.

Otherwise it adds the hamilton repo to the path when sphinx consumes
conf.py. This will mean that the hamilton code is now accessible to be
referenced for when we want to create documentation from those modules.

Note: sphinx will need to have all the right python dependencies in order
to be able to parse that python file.
So that you can change function doc and it'll rebuild the docs.
This is still WIP, but committing to be able to pull and update changes as
needed.
This is probably good enough for now.

This isn't a bad way to do things, it forces more documentation into the class
string of the decorators. It also means that we cannot be sloppy in the reST
string of constructors either.
This should subsume what was there previously.

The docs themselves aren't that pretty -- they could use a little more
whitespace. But otherwise good enough for now.
This is pretty basic. Still need to flesh out the function doc a bit.
We have documents with content to migrate.
So that way we can easily include the main README as the landing page for
the documentation.

Fixes blog, talks, posts to include newer content.
So that we catch weird indentation warnings in dev.

Adds to requirements-docs.txt what readthedocs installs.
Note with myst we can't use the latest sphinx docs.
@skrawcz skrawcz marked this pull request as ready for review February 27, 2023 06:09
@skrawcz skrawcz merged commit d177113 into main Feb 27, 2023
@skrawcz skrawcz deleted the diataxis-docs branch February 27, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants