Reduces max events to 100

[skrawcz]

To reduce overall number of total events
we collect per python process.

Changes

• telemetry.py

How I tested this

Notes

Checklist

• PR has an informative and human-readable title (this will be pulled into the release notes)
• Changes are limited to a single goal (no scope creep)
• Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future TODOs are captured in comments
• Project documentation has been updated if adding/changing functionality.

---

	🚀 This PR description was created by Ellipsis for commit a161238.

Summary:

This PR reduces the maximum number of events collected per Python process from 1000 to 100 in telemetry.py.

Key points:

• Reduced MAX_COUNT_SESSION from 1000 to 100 in telemetry.py

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me!

• Reviewed the entire pull request up to a304fff
• Looked at 14 lines of code in 1 files
• Took 26 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.

1. hamilton/telemetry.py:54:

• Assessed confidence : 50%
• Comment:
  This change reduces the max number of events collected per python process from 1000 to 100. While this might help in reducing the overall number of total events, it could potentially lead to loss of important telemetry data in long-running or complex processes. Please ensure that this change has been adequately tested and that the potential loss of telemetry data is acceptable.
• Reasoning:
  The change in the PR is straightforward and doesn't seem to introduce any bugs. However, it's important to consider the implications of this change. Reducing the max number of events collected per python process from 1000 to 100 could potentially lead to loss of important telemetry data, especially in long-running or complex processes. This could impact the ability to monitor and debug the system effectively. It's also unclear whether this change has been tested adequately, as the PR description doesn't provide any details about testing.

Workflow ID: wflow_4fJPUtdSVXS4Krfq

---

Not what you expected? You can customize the content of the reviews using rules. Learn more here.

[elijahbenizzy]

LGTN

[ellipsis-dev]

👍 Looks good to me!

• Performed an incremental review on a161238
• Looked at 13 lines of code in 1 files
• Took 45 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.

1. hamilton/telemetry.py:54:

• Assessed confidence : 33%
• Comment:
  This change reduces the maximum number of events collected per Python process from 1000 to 100. While this doesn't introduce any bugs, it's important to consider the implications. This could potentially limit the amount of telemetry data collected, which could impact the ability to monitor and improve the system. It could also impact any systems or processes that rely on or expect a certain volume of telemetry data.
• Reasoning:
  The change in the PR is straightforward and doesn't seem to introduce any bugs. However, it's important to consider the implications of this change. Reducing the maximum number of events collected per Python process from 1000 to 100 could potentially limit the amount of telemetry data collected, which could impact the ability to monitor and improve the system. It's also worth noting that this change could potentially impact any systems or processes that rely on or expect a certain volume of telemetry data.

Workflow ID: wflow_hhIKrbaFHwn7YXLX

---

Not what you expected? You can customize the content of the reviews using rules. Learn more here.