Adds image to spark example README #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it clearer what's going on when people land in the directory.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 93ba908
- Looked at
17lines of code in1files - Took 1 minute and 25 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_AjYhfxYqhzdP0rom
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| @@ -24,6 +24,11 @@ Otherwise: | |||
| python spark_pipeline.py | |||
| ``` | |||
|
|
|||
| This is what it'll run: | |||
|  | |||
There was a problem hiding this comment.
The image pipeline.png is referenced here, but it is not included in the PR. Please make sure to add it to the repository in the correct location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it clearer what's going on when people
land in the directory.
Changes
How I tested this
Notes
Checklist
Summary:
This PR enhances the documentation of the spark example in the Hamilton library by adding a visual representation of the dataflow process to the README file.
Key points:
README.mdfile in theexamples/LLM_Workflows/scraping_and_chunking/sparkdirectory.Generated with ❤️ by ellipsis.dev