Adds guard against case in which originating_function is None or source #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrawcz
approved these changes
Mar 19, 2024
hamilton/graph_types.py
Outdated
Comment on lines
160
to
161
| return hash_source_code(self.originating_functions[0], strip=True) | ||
| except Exception: |
code is unavailable. Solves two problems: 1. Originating_functions is None (in the spec) 2. We can't get source code This is currently a high-level exception catch-all. We will likely be narrowing to the specific one. Currently we're only testing the originating_functions for None in unit tests, the other case (an exception) is harder to test for and likely to change.
elijahbenizzy
force-pushed
the
fix-originating-functions-version
branch
from
5e43fcb to
9521df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code is unavailable.
Solves two problems:
This is currently a high-level exception catch-all. We will likely be narrowing to the specific one.
Currently we're only testing the originating_functions for None in unit tests, the other case (an exception) is harder to test for and likely to change.