fix
reduce type constraints on JSON materializer
#774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is a follow-up on #690
Before, the JSON Loader&Saver would only support
dict
type objects. However, the JSON format specs are more flexible. We then introduced support forList[dict]
.However, it seems reasonable to support more generally
list
(ofstr
,int
,None
, etc.). By making it more flexible, we delegate to the underlyingjson
Python library to surface "not json-serializable" errors to the user.Changes
List[dict]
tolist
How I tested this
Notes
Checklist