Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polars spreadsheet type changes #780

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Polars spreadsheet type changes #780

merged 2 commits into from
Mar 25, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Mar 25, 2024

Fixes some type hint issues with spreadsheet writer for polars.

Changes

  • changes type hints
  • adds test

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

skrawcz added 2 commits March 25, 2024 14:00
@skrawcz
Fixes up type hints and imports for polars spreadsheet writer
d2ed07e 
In python 3.9 at least things weren't working. The type hints for
the spreadsheet writer use type aliases that require other imports
to introspect apparently. That is `type_hints = typing.get_type_hints(cls)`
was failing on that class. Adds test for this.
@skrawcz
Adds missing deps to polars materializers example
fb1b17b
@skrawcz skrawcz merged commit 4858121 into main Mar 25, 2024
0 of 4 checks passed
@skrawcz skrawcz deleted the polars_spreadsheet_type_changes branch March 25, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skrawcz