-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ray Remote Options #800
Ray Remote Options #800
Conversation
Ray options allow different resouces to be specified. Functions can then have different resource requirements specified. This is a POC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. @elijahbenizzy might have more thoughts on the decorator than me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I'm in favor of putting this in h_ray
, @skrawcz thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it'd be good to add some unit tests please and then this is ready to ship!
Tests added & now passing :) |
Thanks @flavour 🚀 this will go out this coming week. |
Changes
Support to pass options to ray.remote() via @ray_remote_options() decorator
How I tested this
I setup 4 different Ray nodes with different resources available & then decorated 4 functions to target these nodes and one with no decorator.
I confirmed that the functions ran on the correct nodes when using RayGraphAdapter, just as if I wasn't using Hamilton and that the undecorated function also ran
RayWorkflowGraphAdapter also tested.
Notes
Checklist