Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies the subdag example #82

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Clarifies the subdag example #82

merged 1 commit into from
Feb 28, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy marked this pull request as ready for review February 28, 2023 01:23
@elijahbenizzy elijahbenizzy force-pushed the improve-subdag-example branch 2 times, most recently from c3dc35f to a8a4545 Compare February 28, 2023 01:52
Comment on lines 138 to 140
import pdb

pdb.set_trace()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import pdb
pdb.set_trace()

@elijahbenizzy elijahbenizzy merged commit e080852 into main Feb 28, 2023
@elijahbenizzy elijahbenizzy deleted the improve-subdag-example branch February 28, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants