fix closed CacheAdapter
#847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def run_before_graph_execution(self, *, graph: HamiltonGraph, **kwargs): | ||
| """Set `cache_vars` to all nodes if received None during `__init__`""" | ||
| self.cache = shelve.open(self.cache_path) |
There was a problem hiding this comment.
Something feels wrong about this. Aren't we just opening it again? Feels like it should:
- Open during
init - Run during execution
- Close at the end
There was a problem hiding this comment.
well, that was the previous behavior... I want to have .close() somewhere for safety, but putting it in run_after_graph_execution means you can only run it once
There was a problem hiding this comment.
Won't it just open again? Maybe:
- Open/close during
__init__ - Open during
run_before_graph_execution - Run
- Close at
run_after_graph_execution
?
There was a problem hiding this comment.
I think that's what Thierry just did here?
elijahbenizzy
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CacheAdapter()would successfully run for the first execution, and fail on subsequent ones. This is because the cache was opened on__init__()(needs to read some attributes at instantiation) and closed "after graph execution".Changes
cache is now opened and closed at
__init__()cache is opened "before graph execution" and closed "after graph execution" for satefy