Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to use variables with the driver.execute function #86 #87

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Mar 2, 2023

This implements #86 and enables one to pass driver.Variable objects as expected outputs to the driver.execute(). This reduces the boiler plate for someone to massage getting variables for use with .execute().

Adds to unit test.

Changes

  • adds to driver code for creating the final variables

How I tested this

  • unit test

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This implements #83 and enables one to pass driver.Variable objects
as expected outputs to the driver.execute(). This reduces the boiler
plate for someone to massage getting variables for use with .execute().

Adds to unit test.
@skrawcz skrawcz requested a review from elijahbenizzy March 2, 2023 05:33
@skrawcz skrawcz marked this pull request as ready for review March 2, 2023 05:35
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@elijahbenizzy elijahbenizzy merged commit 6cd4db8 into main Mar 2, 2023
@elijahbenizzy elijahbenizzy deleted the handle_variables branch March 2, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Driver should take in variables to execute as well as functions/node names
2 participants