Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing config from legend #899

Merged
merged 1 commit into from
May 11, 2024
Merged

added missing config from legend #899

merged 1 commit into from
May 11, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented May 8, 2024

Follow-up #872

Changes

  • single line change to add config to node types to include in legend, even when the "config" isn't part of the node path.

How I tested this

  • all tests succeed locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@zilto zilto added the bug Something isn't working label May 8, 2024
@skrawcz skrawcz merged commit 0d175c9 into main May 11, 2024
23 checks passed
@skrawcz skrawcz deleted the fix/missing-config-legend branch May 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants