Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in the Jupyter Magic V2, plugins and other scenarios where we want users to be able to pass a
Builder()
and another function be responsible for completing theDriver
creation.Changes
Builder().copy()
as currently implemented in the Jupyter magics V2 PRHow I tested this
Notes
Currently, the copied
Builder()
holds references to the original Builder attributes. AFAIK, this means the originalBuilder()
can be garbage collected, but not its attribute (assuming they're useful to the new Builder copy. An odd edge case would be:Builder foo
with stateful adaptersBuilder foo
to createBuilder bar
Driver foo
andDriver bar
from both.Driver
seemingly share an adapter with the same state, which could be odd forCachingAdapter
,ExperimentTracker
, and others given they store metadata as they progress through the DAG