Supports delayed evaluation of annotations #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrawcz
approved these changes
Mar 2, 2023
|
Just need to add a good commit message, and ensure graph adapters, etc., also get the requisite change. |
elijahbenizzy
force-pushed
the
issue_91
branch
2 times, most recently
from
1678405 to
2593107
Compare
Luckily the code we have is fairly clean -- this doesn't have a big blast radius. In reality, it should be one spot we make the changes, but we'll have to refactor this later. With __future__ import annotations, python now allows you to lazily evaluate annotations. In <3.10, there is no way to get an inspect.signature with fully evaluated annotations, so we have to use typing.get_type_hints. In 3.10, there's a parameter to force-evaluate signatures, so we can switch to use that when we deprecate 3.9 in quite a while. This is tested in the smoke-screen module -- testing is tricky due to complexity of "future statements". We have to hack up imports, so I chose only to do that in one place.
Yep, works with graph adapters, because we're relying on the produced nodes not the functions -- the abstraction made this generally fairly easy. |
elijahbenizzy
changed the title
Currently there's just a note about postponed evaluation of annotations, but we can add more here over time. This is meant to be specific API reference stuff that doesn't really fit elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist