Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colab links #939

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Add colab links #939

merged 3 commits into from
Jun 13, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jun 5, 2024

Closes #934

Changes

  • adds links where it makes sense.

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

skrawcz added 2 commits June 4, 2024 23:20
We need to fix up our notebooks and redo them with the
new magics -- and then also add notebooks to examples
that don't have them.
Fixes code typoe
examples/dagster/hamilton_code/README.md Outdated Show resolved Hide resolved
"outputs": [],
"execution_count": null,
"source": "#!pip install pandas \"sf-hamilton[dask,visualization]\""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to escape \" quotation marks? Also, might no need the comment #

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is notebook escaping because this is JSON.

examples/dlt/README.md Outdated Show resolved Hide resolved
examples/dagster/hamilton_code/README.md Outdated Show resolved Hide resolved
"outputs": [],
"execution_count": null,
"source": "#!pip install pandas \"sf-hamilton[dask,visualization]\""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is notebook escaping because this is JSON.

examples/dlt/README.md Outdated Show resolved Hide resolved
@skrawcz skrawcz merged commit 6385a82 into main Jun 13, 2024
23 checks passed
@skrawcz skrawcz deleted the add_collab_links branch June 13, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add google collab links for all notebooks
2 participants