Fixes issues in which foreign key IDs were not displayed in the UI (+ a few others) #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
ui-orm-bug-fixes
branch
from
bfb2a3c to
9f2e454
Compare
This is a bit ugly -- we're still identifying the underlying cause, but it turns out that in the SQL orm interaction with django ninja, foreign keys will not show up as IDs. If you have foreign_key_id: int in the model it'll work. So adding this in fixed it.
elijahbenizzy
force-pushed
the
ui-orm-bug-fixes
branch
from
9f2e454 to
29ae1ec
Compare
This is here as some folks did not have it created automatically through django. This is an extra layer but should be a no-op in most cases.
elijahbenizzy
changed the title
skrawcz
reviewed
Jun 14, 2024
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "schemaFile": "http://127.0.0.1:8000/api/openapi.json", | |||
| "schemaFile": "http://127.0.0.1:8241/api/openapi.json", | |||
There was a problem hiding this comment.
just double checking, this is the right port?
skrawcz
reviewed
Jun 14, 2024
skrawcz
reviewed
Jun 14, 2024
skrawcz
approved these changes
Jun 14, 2024
elijahbenizzy
force-pushed
the
ui-orm-bug-fixes
branch
from
89df73a to
23a5c95
Compare
Previously we got a null-pointer type exception. This fixes it by double-checking whether we have no runs.
elijahbenizzy
force-pushed
the
ui-orm-bug-fixes
branch
from
23a5c95 to
df61b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit ugly -- we're still identifying the underlying cause, but it turns out that in the SQL orm interaction with django ninja, foreign keys will not show up as IDs.
If you have foreign_key_id: int in the model it'll work. So adding this in fixed it.