Multiple attributes per node #964
Conversation
elijahbenizzy
force-pushed
the
multiple-attributes
branch
3 times, most recently
from
de47c6b to
a09df1e
Compare
|
elijahbenizzy
force-pushed
the
multiple-attributes
branch
from
2107d36 to
7f4e9e1
Compare
…me task Before we were joining by task name which is incorrect. We can have multiple. This fixes it.
This allows us to display multiple logged attributes. The names are just title-case versions of the keys.
We can't control the environment, but it's printing out the wrong one for mini-mode, which confuses people. If it prints it out for postgres mode in local env it should redirect through a prompt in the UI.
elijahbenizzy
force-pushed
the
multiple-attributes
branch
from
7f4e9e1 to
fcdff36
Compare
elijahbenizzy
changed the title
|
Didn't add tests to the sdk cause this wasn't explicitly tested before, this is a very small change. We have tests on the server side of duplication of task updates. |
| @@ -1,2 +1,2 @@ | |||
| HAMILTON_API_URL = "http://localhost:8241" | |||
| HAMILTON_UI_URL = "http://localhost:8242" | |||
| HAMILTON_UI_URL = "http://localhost:8241" # optimizing for mini-mode | |||
There was a problem hiding this comment.
err -- docs need to be updated then for use with docker then right?
There was a problem hiding this comment.
or there needs to be a way to know which URL to use that the SDK can figure out
There was a problem hiding this comment.
See commit notes, this was the quickest change but yeah we can update docs
There was a problem hiding this comment.
side note: 127.0.0.1 should be preferred to localhost ref.
Also, for mini-mode, the entrypoint 127.0.0.1 should be preferred to 0.0.0.0. But this would provide minimal value if requires a bigger refactoring because Docker-mode would require 0.0.0.0 most likely
There was a problem hiding this comment.
Hmm I'm generally against using a hardcoded value for the purpose of small optimizations, although there are other reasons... Good video.
No description provided.