Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui Misc UI changes #974

Merged
merged 7 commits into from
Jun 23, 2024
Merged

ui Misc UI changes #974

merged 7 commits into from
Jun 23, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Jun 20, 2024

Here's a video displaying and explaining some changes

Changes

  • "Information" now opens the docs in a new tab instead of the current one
  • The yellow feedback button is now part of the sidebar and no longer a floating component
  • the sidebar now properly displayed on narrow screens (there are still issues with the hamburger menu)
  • Removed the tab sections hierarchy when navigating a project (i.e., Structure, and Runs)
  • Moved the video links (yellow ?) to other tabs since Structure and Runs were removed
  • Removed the "Version" tab and made it accessible through the version X text
  • Changed v. X to version X
  • Removed the "Account" icon at the bottom of the project sidebar since it served the same functionality as the top sidebar
  • Changed project tabs so that hover uses the pointer icon (i.e., the mouse has the small hand instead of the arrow) and made the text non-selectable

How I tested this

  • manual testing

@zilto zilto added the UI Related to the Hamilton UI label Jun 20, 2024
@elijahbenizzy
Copy link
Collaborator

Remove the hamburger menu all together

@elijahbenizzy
Copy link
Collaborator

The sidebar feels squished -- can we make it wider?
image

Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zilto zilto merged commit 29a21f4 into main Jun 23, 2024
24 checks passed
@zilto zilto deleted the ui/open-link-newtab branch June 23, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Related to the Hamilton UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants