Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in NodeFilter type alias in hamilton/lifecycle/default.py #977

Merged

Conversation

ChronoJon
Copy link
Contributor

Noticed a typo in the NodeFilter type alias in hamilton/lifecycle/default.py and fixed it.
I then ran pre-commit on it to format it with black.

Note

Tests did not pass, because numpy 2.0 threw a lot of errors (perhaps version should be constrained to <2.0). Even with numpy<2.0 there were still dependencies missing, so I ignored test results, as the changes just affect typing.

Checklist

  • [x ] PR has an informative and human-readable title (this will be pulled into the release notes)
  • [ x] Changes are limited to a single goal (no scope creep)
  • [ x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.

Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the find! You are correct. Will merge shortly.

@elijahbenizzy elijahbenizzy merged commit ee91be9 into DAGWorks-Inc:main Jun 21, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants