Gives user visibility into whether nodes are external inputs or not #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to programmatically determine the inputs to your DAG. One component of #97.
skrawcz
reviewed
Mar 5, 2023
| @@ -69,7 +69,8 @@ class Variable: | |||
|
|
|||
| name: str | |||
| type: typing.Type | |||
| tags: Dict[str, str] = field(default_factory=frozenset) | |||
| tags: Dict[str, str] = field(default_factory=dict) | |||
| is_external_input: bool = field(default=False) | |||
There was a problem hiding this comment.
we use UD in visualizing the DAG -- so should it be is_user_defined_input / is_user_provided_input instead?
There was a problem hiding this comment.
If anything we should change that -- user_defined to me makes less sense than external. Also UD is confusing without a legend...
There was a problem hiding this comment.
Yep sure. I'm just thinking about language. @gravesee do you have any preference here?
skrawcz
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to programmatically determine the inputs to your DAG. One component of #97.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist