Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode extension and LSP migration and release #992

Merged
merged 15 commits into from
Jul 2, 2024
Merged

VSCode extension and LSP migration and release #992

merged 15 commits into from
Jul 2, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Jun 27, 2024

The Hamilton VSCode extension is available through the VSCode marketplace.

It is powered by the sf-hamilton-lsp published on PyPi and aliases to sf-hamilton[lsp]

The documentation has been updated too.

TODO

  • add tests for LSP
  • better communicate to the user when the viz should be reloaded
  • better communicate when Python dependencies are missing
  • add automated documentation for LSP code (i.e., a "Reference" section)
  • unify the documentation and the extension walkthrough feature

@zilto zilto added documentation Improvements or additions to documentation enhancement New feature or request lsp Language server issues vscode Hamilton VSCode issue labels Jun 27, 2024
skrawcz
skrawcz reviewed Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. One thing I found.

elijahbenizzy
elijahbenizzy reviewed Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some very minor comments. Should merge then we can revisit asynchronously.

dev_tools/language_server/hamilton_lsp/server.py Outdated Show resolved Hide resolved
dev_tools/language_server/tests/conftest.py Show resolved Hide resolved
dev_tools/language_server/tests/ls_setup.py
CALL_TIMEOUT = 3


def retry_stalled_init_fix_hack():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments?

@skrawcz skrawcz force-pushed the feat/vscode-lsp-release branch from 1ebee3b to ff6fa33 Compare July 2, 2024 00:38
@skrawcz skrawcz force-pushed the feat/vscode-lsp-release branch from ff6fa33 to d2535d1 Compare July 2, 2024 00:46
@skrawcz skrawcz merged commit d12f4dc into main Jul 2, 2024
22 checks passed
@skrawcz skrawcz deleted the feat/vscode-lsp-release branch July 2, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elijahbenizzy elijahbenizzy elijahbenizzy left review comments

@skrawcz skrawcz skrawcz left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request lsp Language server issues vscode Hamilton VSCode issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zilto @skrawcz @elijahbenizzy