Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extra guards for plugin imports #994

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Adds extra guards for plugin imports #994

merged 1 commit into from
Jul 2, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jun 28, 2024

We should probably just blanket catch all errors -- but not doing that right now. Hamilton fails to be imported in a spark serverless environment because there is some interaction with DLT that databricks doesn't like.

So catching more exceptions -- and shoe horning it into an import error.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

We should probably just blanket catch all errors -- but
not doing that right now. Hamilton fails to be imported
in a spark serverless environment because there is some
interaction with DLT that databricks doesn't like.

So catching more exceptions -- and shoe horning it into
an import error.
@skrawcz skrawcz marked this pull request as ready for review July 1, 2024 18:53
@skrawcz
Copy link
Collaborator Author

skrawcz commented Jul 1, 2024

Verified this works with RC version.

@skrawcz skrawcz merged commit 929e4fd into main Jul 2, 2024
19 checks passed
@skrawcz skrawcz deleted the extra_dlt_guard branch July 2, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant