Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds deployable mini-mode #996

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Adds deployable mini-mode #996

merged 6 commits into from
Jul 5, 2024

Conversation

elijahbenizzy
Copy link
Collaborator

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy force-pushed the mini-mode-upgrades branch 5 times, most recently from f2a5d2b to 81825be Compare July 3, 2024 04:14
@elijahbenizzy
Adds deployable mini-mode
26ebc37
@elijahbenizzy
Allows blob_storage to specify endpoint url
2cfe13d 
This enables alternate S3 implementations
@elijahbenizzy
Allows static files to be served in non-debug mode
cac2481 
There is a simple flag that allows it. While we really should be not
using the django server, this is OK for now. This is necessary as django
does not, by default, serve static files in non-debug mode. We want that
to happen so someone can run this. We will be providing a more
production-blessed path soon, but this unblocks our users.
@elijahbenizzy
Adds global password to authentication for local mode
d2a5934 
This is not meant to deploy in production unless it is specifically at
ones own risk inside their guarded VPN. This is specifically meant to
have a very lightweight (not particularly secure, but usable)
authentication system with a single global password.
@elijahbenizzy elijahbenizzy marked this pull request as ready for review July 3, 2024 17:20
@elijahbenizzy
Adds authentication guard + redirects to login in local mode
1dcd1ca 
This is generally a no-op, but it is nice to have for the local
authenticated version. A bit of a hack, but this is really just a quick
way to get something up and running. In the medium term we will be
changing the way we do auth to be more unified.
@elijahbenizzy
Removes unecessary comments in setup.py for spark target
985d5c0
@elijahbenizzy elijahbenizzy merged commit 327a3f3 into main Jul 5, 2024
18 of 25 checks passed
@elijahbenizzy elijahbenizzy deleted the mini-mode-upgrades branch July 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijahbenizzy @skrawcz