Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DD-1685: Check for expired token
Description of changes
How to test
See added unit tests. authenticate_should_return_401_for_expired_dataverse_key failed before the query was fixed.
PS: The tests create their own tables. This introduces a risk of false positives due to typos compared to the actual dvndb, or changes in the dvndb. So also tested after compilation and deploy with:
Use actual values for 999 and xxx and reset the
expiretime
after the test. Before the DB change, curl returns 200-OK, after the change 401-Unauthorized.Related PRs
(Add links)
*
Notify
@DANS-KNAW/core-systems