Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stricter warnings for apps that use them #2264

Closed
lifflander opened this issue Apr 9, 2024 · 2 comments · Fixed by #2282
Closed

Add stricter warnings for apps that use them #2264

lifflander opened this issue Apr 9, 2024 · 2 comments · Fixed by #2282
Assignees
@cz4rs
Labels
type: task

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

Add stricter warnings to cmake build
@cz4rs cz4rs self-assigned this May 7, 2024
@cz4rs
Copy link
Contributor

cz4rs commented May 7, 2024

See DARMA-tasking/magistrate#333 for a similar issue in magistrate.

cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: cmake: enable more warnings
5e8075d 
Enable more warnings and sort the flags alphabetically.
@cz4rs cz4rs mentioned this issue May 9, 2024
Merged
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: fix non-virtual-dtor and suggest-override warnings
4307ec2
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: cmake: remove flags for unsupported compilers
a893b75
@cz4rs
Copy link
Contributor

cz4rs commented May 9, 2024

TODO: also consider fixing codacy issues, there are some interesting ones listed.

cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: remove unused variable
a366562
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: add FIXME for warning
2049db6
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: remove unused variable
062dd74
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: use const reference when possible
896389e
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: scripts: remove unused variables
77728e7
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: use range-based loop
fa21b28
cz4rs added a commit that referenced this issue May 9, 2024
@cz4rs
#2264: simplify if logic
929566e
cz4rs added a commit that referenced this issue May 10, 2024
@cz4rs
#2264: cmake: enable -Wextra
6fe9ed0
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
2d3c1b3
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
5bff41e
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix remaining warnings (gcc)
e8f7a1f
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
e3eee52
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
9b1d445
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
19f1cbf
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
9c06603
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
8f5c586
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
35d1931
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
94f5b89
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: appease gcc-9
18815d1
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: remove unused parameters
80f2415
cz4rs added a commit that referenced this issue May 14, 2024
@cz4rs
#2264: fix unused variable warnings
9ec793f
cz4rs added a commit that referenced this issue May 15, 2024
@cz4rs
#2264: fix unused variable warnings (cuda, hip)
2031cf0
cz4rs added a commit that referenced this issue May 28, 2024
@cz4rs
#2264: remove unused parameters
72317d9
cz4rs added a commit that referenced this issue May 28, 2024
@cz4rs
#2264: fix unused variable warnings
ea50fd8
cz4rs added a commit that referenced this issue May 28, 2024
@cz4rs
#2264: fix unused variable warnings (cuda, hip)
d7735fa
cz4rs added a commit that referenced this issue May 28, 2024
@cz4rs
#2264: work around gcc-8 limitations
70cbc30
cz4rs added a commit that referenced this issue May 28, 2024
@cz4rs
#2264: remove unnecessary #include
d141682
cz4rs added a commit that referenced this issue May 28, 2024
@cz4rs
#2264: simplify ternary expression
13c5b76
cz4rs added a commit that referenced this issue May 28, 2024
@cz4rs
#2264: remove unused parameter
38de7db
nlslatt added a commit that referenced this issue May 28, 2024
@nlslatt
Merge pull request #2282 from DARMA-tasking/2264-enable-more-warnings
faba6a5 
#2264: Add stricter warnings for apps that use them
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: cmake: enable more warnings
59b59e9 
Enable more warnings and sort the flags alphabetically.
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: fix non-virtual-dtor and suggest-override warnings
93aac5f
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: cmake: remove flags for unsupported compilers
89b30cb
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: remove unused variable
af2010f
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: add FIXME for warning
b92332d
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: remove unused variable
d8054a9
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: use const reference when possible
c23b5b5
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: scripts: remove unused variables
5f87e6c
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: use range-based loop
7e21995
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: simplify if logic
11239c5
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: cmake: enable -Wextra
c07a1a8
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: fix unused variable warnings
1781b1c
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: fix remaining warnings (gcc)
7724632
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: fix unused variable warnings
c843314
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: remove unused parameters
02bb40a
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: fix unused variable warnings
f76c67a
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: fix unused variable warnings (cuda, hip)
97b0ad1
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: work around gcc-8 limitations
53571e5
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: remove unnecessary #include
1eb7186
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: simplify ternary expression
4fe5d27
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@cz4rs @cwschilly
#2264: remove unused parameter
07ade3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cz4rs cz4rs

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2264: Add stricter warnings for apps that use them DARMA-tasking/vt
2 participants
@lifflander @cz4rs