Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2318: Fix and issue with multicast not sending to all required nodes #2327

Merged
merged 1 commit into from
Jul 17, 2024
+23 −6
Merged

#2318: Fix and issue with multicast not sending to all required nodes #2327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions src/vt/objgroup/proxy/proxy_objgroup.impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ Proxy<ObjT>::multicast(GroupType type, Params&&... params) const{
template <typename ObjT>
template <auto f, typename... Params>
typename Proxy<ObjT>::PendingSendType Proxy<ObjT>::multicast(
group::region::Region::RegionUPtrType&& nodes, Params&&... params) const {
group::region::Region::RegionUPtrType&& nodes, Params&&... params
) const {
vtAssert(
not dynamic_cast<group::region::ShallowList*>(nodes.get()),
"multicast: range of nodes is not supported for ShallowList!"
Expand All @@ -150,13 +151,29 @@ typename Proxy<ObjT>::PendingSendType Proxy<ObjT>::multicast(

auto groupID = theGroup()->GetTempGroupForRange(range);
if (!groupID.has_value()) {
groupID = theGroup()->newGroup(
std::move(nodes), []([[maybe_unused]] GroupType type) {}
);
theGroup()->AddNewTempGroup(range, groupID.value());
return typename Proxy<ObjT>::PendingSendType{
theTerm()->getCurrentEpoch(),
[&, this,
args = std::make_tuple(std::forward<Params>(params)...)] {
std::apply(
[&, this](auto&&... unpackedArgs) {
// Explicit copy, we move 'nodes' in group creation
auto range_copy = nodes->makeList();
auto id =
theGroup()->newGroup(std::move(nodes), [&, this](GroupType type) {
multicast<f>(
type, std::forward<decltype(unpackedArgs)>(unpackedArgs)...);
});
theGroup()->AddNewTempGroup(range_copy, id);
},
std::move(args));
}};
} else {
return multicast<f>(groupID.value(), std::forward<Params>(params)...);
}

return multicast<f>(groupID.value(), std::forward<Params>(params)...);
// Silence nvcc warning (no longer needed for CUDA 11.7 and up)
return typename Proxy<ObjT>::PendingSendType{std::nullptr_t{}};
}

template <typename ObjT>
Expand Down