#2342: Change schema to allow for `id` or `seq_id` #2343

cwschilly · 2024-09-05T19:50:00Z

github-actions · 2024-09-05T19:55:12Z

Pipelines results

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for 5381a4c (2024-09-09 17:29:39 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

/vt/tests/perf/send_cost.cc(169): warning #177-D: variable "prevNode" was declared but never referenced
    auto const prevNode = (thisNode - 1 + num_nodes_) % num_nodes_;
               ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

Testing - passed

Build log

…bit-encoded; add unit test

…field

nlslatt

Some comments below. Please familiarize yourself with the vt style guidelines (function naming, etc.). I'm still looking at the tests but wanted to give you feedback on the main implementation right away.

src/vt/vrt/collection/balance/lb_data_holder.cc

nlslatt

Almost there

src/vt/vrt/collection/balance/lb_data_holder.h

nlslatt

Looks good

cwschilly linked an issue Sep 5, 2024 that may be closed by this pull request

Change schema to allow for id or seq_id #2342

Closed

cwschilly marked this pull request as draft September 5, 2024 19:50

cwschilly self-assigned this Sep 5, 2024

cwschilly added 5 commits September 6, 2024 14:06

#2342: update schema to support seq_id in tasks field when id is not …

c849bdb

…bit-encoded; add unit test

#2342: wip: add logic for supporting or creating encoded ids in comm …

8138dec

…field

#2342: reduce duplication and improve bool naming

c36b530

#2342: fix scope error

9386580

#2342: add communications to LBDataHolder test

a9ec85f

cwschilly force-pushed the 2342-change-schema-to-allow-for-id-or-seq_id branch from c8fc9e6 to a9ec85f Compare September 6, 2024 18:06

cwschilly marked this pull request as ready for review September 6, 2024 18:08

cwschilly requested review from lifflander, cz4rs, thearusable, JacobDomagala and nlslatt September 6, 2024 18:09

cwschilly added 3 commits September 6, 2024 14:09

#2342: remove todo comment

dc4903b

#2342: resolve warnings

530ff58

#2342: fix id_key declaration in validator script

4741dc8

nlslatt reviewed Sep 6, 2024

View reviewed changes

src/vt/vrt/collection/balance/lb_data_holder.cc Outdated Show resolved Hide resolved

src/vt/vrt/collection/balance/lb_data_holder.cc Outdated Show resolved Hide resolved

src/vt/vrt/collection/balance/lb_data_holder.cc Show resolved Hide resolved

cwschilly mentioned this pull request Sep 6, 2024

Update JSON generator to work with vt's LBDataHolder DARMA-tasking/LB-analysis-framework#527

Closed

4 tasks

#2342: simplify logic by creating elms directly from encoded ids

411ccdb

nlslatt reviewed Sep 9, 2024

View reviewed changes

src/vt/vrt/collection/balance/lb_data_holder.h Outdated Show resolved Hide resolved

#2342: initialize this_node_ with vt::uninitialized_destination

5381a4c

nlslatt approved these changes Sep 9, 2024

View reviewed changes

nlslatt merged commit 7045f0a into develop Sep 9, 2024
26 checks passed

tlamonthezie mentioned this pull request Sep 11, 2024

#527: Update JSON generator to work with vt's LBDataHolder DARMA-tasking/LB-analysis-framework#528

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2342: Change schema to allow for `id` or `seq_id` #2343

#2342: Change schema to allow for `id` or `seq_id` #2343

cwschilly commented Sep 5, 2024

github-actions bot commented Sep 5, 2024 •

edited

Loading

nlslatt left a comment

nlslatt left a comment

nlslatt left a comment

#2342: Change schema to allow for id or seq_id #2343

#2342: Change schema to allow for id or seq_id #2343

Conversation

cwschilly commented Sep 5, 2024

github-actions bot commented Sep 5, 2024 • edited Loading

Pipelines results

nlslatt left a comment

Choose a reason for hiding this comment

nlslatt left a comment

Choose a reason for hiding this comment

nlslatt left a comment

Choose a reason for hiding this comment

#2342: Change schema to allow for `id` or `seq_id` #2343

#2342: Change schema to allow for `id` or `seq_id` #2343

github-actions bot commented Sep 5, 2024 •

edited

Loading