Skip to content

Commit

Permalink
clean up old notebook css (#5945)
Browse files Browse the repository at this point in the history 
Co-authored-by: Daniel Chang <mwdchang@gmail.com>
  • Loading branch information
@shawnyama @mwdchang
shawnyama and mwdchang authored Jan 3, 2025
1 parent 530a490 commit f9e1b0e
Show file tree
Hide file tree
Showing 6 changed files with 82 additions and 119 deletions.
1 change: 0 additions & 1 deletion packages/client/hmi-client/src/components/llm/tera-notebook-jupyter-input.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ const onInputChange = async () => {
.notebook-toolbar {
display: flex;
flex-direction: row;
margin-top: var(--gap-2);
gap: var(--gap-3);
justify-content: space-between;
}
Expand Down
37 changes: 13 additions & 24 deletions ...i-client/src/components/workflow/ops/model-comparison/tera-model-comparison-drilldown.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -117,21 +117,19 @@
<!--TODO: The notebook input and buttons works well here, but it the html/css
organization should be refactored here (same for tera-model-edit)-->
<tera-drilldown-section class="notebook-section">
<div class="toolbar">
<tera-notebook-jupyter-input
:kernelManager="kernelManager"
:defaultOptions="sampleAgentQuestions"
@llm-output="appendCode"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="llmThoughts = []"
:context-language="contextLanguage"
>
<template #toolbar-right-side>
<Button label="Reset" outlined severity="secondary" size="small" @click="resetNotebook" />
<Button icon="pi pi-play" label="Run" size="small" @click="runCode" :disabled="isEmpty(code)" />
</template>
</tera-notebook-jupyter-input>
</div>
<tera-notebook-jupyter-input
:kernelManager="kernelManager"
:defaultOptions="sampleAgentQuestions"
@llm-output="appendCode"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="llmThoughts = []"
:context-language="contextLanguage"
>
<template #toolbar-right-side>
<Button label="Reset" outlined severity="secondary" size="small" @click="resetNotebook" />
<Button icon="pi pi-play" label="Run" size="small" @click="runCode" :disabled="isEmpty(code)" />
</template>
</tera-notebook-jupyter-input>
<v-ace-editor
v-model:value="code"
@init="initializeAceEditor"
Expand Down Expand Up @@ -699,15 +697,6 @@ ul {
position: relative;
}
.toolbar-right-side {
position: absolute;
top: var(--gap-4);
right: 0;
gap: var(--gap-2);
display: flex;
align-items: center;
}
.comparison-overview,
.comparison-context {
border: 1px solid var(--surface-border-light);
Expand Down
43 changes: 16 additions & 27 deletions ...lient/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -167,24 +167,22 @@
</tera-drilldown-section>
<tera-columnar-panel :tabName="DrilldownTabs.Notebook">
<tera-drilldown-section class="notebook-section">
<div class="toolbar">
<Suspense>
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:defaultOptions="sampleAgentQuestions"
:maxChars="60"
:context-language="contextLanguage"
@llm-output="(data: any) => appendCode(data, 'code')"
@llm-thought-output="(data: any) => updateThoughts(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<tera-input-text v-model="knobs.transientModelConfig.name" placeholder="Configuration Name" />
<Button icon="pi pi-play" label="Run" @click="runFromCode" :disabled="isEmpty(codeText)" />
</template>
</tera-notebook-jupyter-input>
</Suspense>
</div>
<Suspense>
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:defaultOptions="sampleAgentQuestions"
:maxChars="60"
:context-language="contextLanguage"
@llm-output="(data: any) => appendCode(data, 'code')"
@llm-thought-output="(data: any) => updateThoughts(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<tera-input-text v-model="knobs.transientModelConfig.name" placeholder="Configuration Name" />
<Button icon="pi pi-play" label="Run" @click="runFromCode" :disabled="isEmpty(codeText)" />
</template>
</tera-notebook-jupyter-input>
</Suspense>
<v-ace-editor
v-model:value="codeText"
@init="initializeEditor"
Expand Down Expand Up @@ -904,15 +902,6 @@ onUnmounted(() => {
position: relative;
}
.toolbar-right-side {
position: absolute;
top: var(--gap-4);
right: 0;
gap: var(--gap-2);
display: flex;
align-items: center;
}
#matrix-canvas {
position: fixed;
top: 0;
Expand Down
46 changes: 22 additions & 24 deletions ...es/client/hmi-client/src/components/workflow/ops/model-edit/tera-model-edit-drilldown.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,30 +9,28 @@
@update-state="(state: any) => emit('update-state', state)"
>
<tera-drilldown-section :tabName="DrilldownTabs.Notebook" class="notebook-section">
<div class="toolbar">
<Suspense>
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:default-options="sampleAgentQuestions"
:context-language="contextLanguage"
@llm-output="(data: any) => appendCode(data, 'code')"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<Button label="Reset" outlined severity="secondary" size="small" @click="resetModel" />
<Button
icon="pi pi-play"
:label="isUpdatingModel ? 'Loading...' : 'Run'"
size="small"
:loading="isUpdatingModel"
@click="runCode"
:disabled="isEmpty(codeText)"
/>
</template>
</tera-notebook-jupyter-input>
</Suspense>
</div>
<Suspense>
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:default-options="sampleAgentQuestions"
:context-language="contextLanguage"
@llm-output="(data: any) => appendCode(data, 'code')"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<Button label="Reset" outlined severity="secondary" size="small" @click="resetModel" />
<Button
icon="pi pi-play"
:label="isUpdatingModel ? 'Loading...' : 'Run'"
size="small"
:loading="isUpdatingModel"
@click="runCode"
:disabled="isEmpty(codeText)"
/>
</template>
</tera-notebook-jupyter-input>
</Suspense>
<v-ace-editor
v-model:value="codeText"
@init="initializeAceEditor"
Expand Down
34 changes: 12 additions & 22 deletions ...hmi-client/src/components/workflow/ops/simulate-ciemss/tera-simulate-ciemss-drilldown.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
content-width="420px"
>
<template #content>
<div class="toolbar">
<div class="flex align-items-center justify-content-between px-3">
<p>{{ blankMessage }}.</p>
<span class="flex gap-2">
<tera-pyciemss-cancel-button :simulation-run-id="cancelRunIds" />
Expand Down Expand Up @@ -104,19 +104,17 @@

<!-- Notebook -->
<tera-drilldown-section :tabName="DrilldownTabs.Notebook" class="notebook-section">
<div class="toolbar">
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:context-language="'python3'"
@llm-output="(data: any) => processLLMOutput(data)"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<Button label="Run" size="small" icon="pi pi-play" @click="runCode" :disabled="isEmpty(codeText)" />
</template>
</tera-notebook-jupyter-input>
</div>
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:context-language="'python3'"
@llm-output="(data: any) => processLLMOutput(data)"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<Button label="Run" size="small" icon="pi pi-play" @click="runCode" :disabled="isEmpty(codeText)" />
</template>
</tera-notebook-jupyter-input>
<v-ace-editor
v-model:value="codeText"
@init="initializeAceEditor"
Expand Down Expand Up @@ -851,14 +849,6 @@ onUnmounted(() => kernelManager.shutdown());
</script>

<style scoped>
.wizard .toolbar {
display: flex;
align-items: center;
justify-content: space-between;
padding: var(--gap-1) var(--gap-4);
gap: var(--gap-2);
}
/* Make tera-inputs the same height as the dropdowns */
.tera-input:deep(main) {
padding: 6px;
Expand Down
40 changes: 19 additions & 21 deletions ...s/client/hmi-client/src/components/workflow/ops/stratify-mira/tera-stratify-drilldown.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,27 +37,25 @@
</div>
<div :tabName="StratifyTabs.Notebook">
<tera-drilldown-section class="notebook-section">
<div class="toolbar">
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:default-options="sampleAgentQuestions"
:context-language="'python3'"
@llm-output="(data: any) => processLLMOutput(data)"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<Button
:loading="isStratifyInProgress"
:label="isStratifyInProgress ? 'Loading...' : 'Run'"
size="small"
icon="pi pi-play"
@click="runCodeStratify"
:disabled="isEmpty(codeText)"
/>
</template>
</tera-notebook-jupyter-input>
</div>
<tera-notebook-jupyter-input
:kernel-manager="kernelManager"
:default-options="sampleAgentQuestions"
:context-language="'python3'"
@llm-output="(data: any) => processLLMOutput(data)"
@llm-thought-output="(data: any) => llmThoughts.push(data)"
@question-asked="updateLlmQuery"
>
<template #toolbar-right-side>
<Button
:loading="isStratifyInProgress"
:label="isStratifyInProgress ? 'Loading...' : 'Run'"
size="small"
icon="pi pi-play"
@click="runCodeStratify"
:disabled="isEmpty(codeText)"
/>
</template>
</tera-notebook-jupyter-input>
<v-ace-editor
v-model:value="codeText"
@init="initialize"
Expand Down

0 comments on commit f9e1b0e

Please sign in to comment.